Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open-DKIM key generation broken #3535

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

luke-
Copy link
Contributor

@luke- luke- commented Sep 12, 2023

With ENABLE_OPENDKIM=1 and ENABLE_RSPAMD=1 it's currently not possible to create DKIM Keys

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

With `ENABLE_OPENDKIM=1` and `ENABLE_RSPAMD=1` it's currently not possible to create DKIM Keys
@georglauterbach
Copy link
Member

Good observation! I'd actually like to error-out in a fail-fast way. This patch would hide a misconfiguration. I will add a suggestion.

target/bin/open-dkim Outdated Show resolved Hide resolved
Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
@luke-
Copy link
Contributor Author

luke- commented Sep 12, 2023

@georglauterbach Thanks, just merged your suggestion.
Fyi: Not tested it. I'm not a bash scripting pro. Is there a fi missing?

@georglauterbach
Copy link
Member

@georglauterbach Thanks, just merged your suggestion.

Fyi: Not tested it. I'm not a bash scripting pro. Is there a fi missing?

There is 😂 Good observation!

@luke-
Copy link
Contributor Author

luke- commented Sep 13, 2023

Ok, I've fixed and tested it.

@georglauterbach
Copy link
Member

Tests running now. I'll merge when all tests check out.

@georglauterbach georglauterbach merged commit 86edaf9 into docker-mailserver:master Sep 13, 2023
7 checks passed
@luke- luke- deleted the patch-1 branch September 13, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants