Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TLS - Include passthrough=true on implicit ports for Traefik example #3568

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

vincentDcmps
Copy link
Contributor

Description

like discuss in #3563 I have add the passthrought option in reverse proxy doc

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind approving this change. Although I'd love it if there was a more consistent config experience with Traefik since several users reported recently having success and failure with different ports 🤔

- "traefik.tcp.routers.smtp-ssl.entrypoints=smtp-ssl"
- "traefik.tcp.routers.smtp-ssl.tls.passthrough=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


Reference:

Doesn't require tls=false, but should hand the traffic over to DMS on port 465 encrypted, and DMS will handle the connection (and presumably certs).

Related:

- "traefik.tcp.routers.smtp-ssl.service=smtp-ssl"
- "traefik.tcp.services.smtp-ssl.loadbalancer.server.port=465"
- "traefik.tcp.services.smtp-ssl.loadbalancer.proxyProtocol.version=1"
- "traefik.tcp.routers.imap-ssl.rule=HostSNI(`*`)"
- "traefik.tcp.routers.imap-ssl.entrypoints=imap-ssl"
- "traefik.tcp.routers.imap-ssl.service=imap-ssl"
- "traefik.tcp.routers.esmtp.tls.passthrough=true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to reference the imap-ssl router not esmtp?:

Suggested change
- "traefik.tcp.routers.esmtp.tls.passthrough=true"
- "traefik.tcp.routers.imap-ssl.tls.passthrough=true"

I'm not familiar with why the proxyProtocol.version is sometimes 1 or 2, perhaps due to Postfix / Dovecot support? I understand it's to ensure that the original client IP is handed over correctly so it doesn't get misunderstood as directly from Traefik. But I'm not sure if that's required for each different supported way that Traefik routes to different DMS ports 🤷‍♂️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Documentation preview for this PR is ready! 🎉

Built with commit: 7fc3def

@polarathene polarathene changed the title docs: add passthrought on traefik reverse proxy config to implicit port docs: TLS - Include passthrough=true on implicit ports for Traefik example Oct 7, 2023
@polarathene polarathene merged commit 82c38f2 into docker-mailserver:master Oct 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants