Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set virtual_mailbox_maps to texthash when not using LDAP #3693

Merged
merged 2 commits into from
Dec 10, 2023
Merged

fix: only set virtual_mailbox_maps to texthash when not using LDAP #3693

merged 2 commits into from
Dec 10, 2023

Conversation

reneploetz
Copy link
Contributor

Fixes #3692

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@reneploetz
Only set virtual_mailbox_maps to texthash when using the FILE account…
91b9c9b 
… provisioner

Signed-off-by: René Plötz <reneploetz@users.noreply.github.com>
@reneploetz
Copy link
Contributor Author

reneploetz commented Dec 10, 2023 •
edited

Note that one could think about moving the comment into the condition so that comment and change are closer to each other. I just opted for the smallest change here.

@georglauterbach georglauterbach added this to the v13.1.0 milestone Dec 10, 2023
@georglauterbach georglauterbach changed the title Only set virtual_mailbox_maps to texthash when using the FILE account… LDAP: only set virtual_mailbox_maps to texthash when not using LDAP Dec 10, 2023
polarathene
polarathene approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, sorry about the bug! 😬

@polarathene polarathene changed the title LDAP: only set virtual_mailbox_maps to texthash when not using LDAP fix: only set virtual_mailbox_maps to texthash when not using LDAP Dec 10, 2023
@polarathene polarathene merged commit 2f5dfed into docker-mailserver:master Dec 10, 2023
7 checks passed
reneploetz added a commit to reneploetz/docker-mailserver that referenced this pull request Dec 20, 2023
@reneploetz
fix: Only set virtual_mailbox_maps to texthash when using the `FI…
4ead1c2 
…LE` account provisioner (docker-mailserver#3693)

Signed-off-by: René Plötz <reneploetz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@reneploetz reneploetz

Labels
area/scripts kind/bug/fix A fix (PR) for a confirmed bug service/ldap
Projects
None yet
Milestone
v13.1.0
Development

Successfully merging this pull request may close these issues.

LDAP integration is broken in current edge
4 participants
@reneploetz @casperklein @polarathene @georglauterbach