-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Avoiding linting CONTRIBUTORS.yml
#3705
Conversation
The file is managed by the `contributors.yml` workflow, no need for linting to be triggered on PRs for that change.
So what is achieved by this PR? This PR does not seem to change the status quo at all (at least to me). |
See the first link, there is a lint workflow that wasn't triggered, blocking @casperklein and myself from approving + merging the PR. The lint workflow isn't relevant to that PR type, so the idea here was to have it ignored which should be an automatic pass (skip) avoiding the concern? If you disagree that's fine, it's an issue that happens a few times a year and can alternatively be solved by waiting for |
Is this really the case? I mean, is ignoring it an automatic pass? The issue at hand is that one workflow can not trigger workflows by opening a new PR. But because the linting workflow is required for all PRs, we end up in the situation we're in as of now. It definitely does not hurt to merge this PR, maybe it even solves our problem. We'll see; I'll have a look at the next PR for contributors. |
The docs say that, see that last screenshot (with the purple highlight) I shared in the PR description.
Ah, that makes sense, thanks :) |
The file is managed by the `contributors.yml` workflow, no need for linting to be triggered on PRs for that change. This should ideally skip the required check status for the lint workflow which cannot trigger implicitly for automated PRs. If this doesn't work the change should be reverted.
Description
contributors.yml
workflow, no need for linting to be triggered on PRs for that change.CONTRIBUTORS.md
.Disregard different feature
NOTE:
paths
/paths-ignore
rules.The linked blogpost is from Aug 2023, announcing deprecation and shutdown of the feature in October. I could be mistaken if this was the feature used with the linting workflow, I just recall it being managed as a required check status which required authorization to modify the organization settings which @georglauterbach has permissions for.
EDIT: Seems like I mixed up a different feature, and this is just the required status check, so we can probably rely on this PR to skip it for the file, which will treat it as successful 👍