[TODO]: Tests(Fail2Ban) - Make failed login test case reliable

[polarathene]

Description

This test case is quite flakey, and fails on PRs that have nothing to do with it.

not ok 52 [Fail2Ban] ban ip on multiple failed login in 132455ms
# (from function `assert_success' in file test/test_helper/bats-assert/src/assert_success.bash, line 42,
#  from function `_send_email' in file test/helper/sending.bash, line 33,
#  in test file test/tests/parallel/set1/spam_virus/fail2ban.bats, line 77)
#   `CONTAINER_NAME=${CONTAINER2_NAME} _send_email 'auth/smtp-auth-login-wrong' "${CONTAINER1_IP} 465"' failed
#
# -- command failed --
# status : 1
# output :
# --
#

Seems like it's something to do with _send_email failing?

docker-mailserver/test/tests/parallel/set1/spam_virus/fail2ban.bats

Line 77 in ee87291

CONTAINER_NAME=${CONTAINER2_NAME} _send_email 'auth/smtp-auth-login-wrong' "${CONTAINER1_IP} 465"

docker-mailserver/test/helper/sending.bash

Lines 22 to 34 in ee87291

	# This function will just send the email in an "asynchronous" fashion, i.e. it will
	# send the email but it will not make sure the mail queue is empty after the mail
	# has been sent.
	function _send_email() {
	local TEMPLATE_FILE=${1:?Must provide name of template file}
	local NC_PARAMETERS=${2:-0.0.0.0 25}
	assert_not_equal "${NC_PARAMETERS}" ''
	assert_not_equal "${CONTAINER_NAME:-}" ''
	_run_in_container_bash "nc ${NC_PARAMETERS} < /tmp/docker-mailserver-test/${TEMPLATE_FILE}.txt"
	assert_success
	}

Specifically this line:

docker-mailserver/test/helper/sending.bash

Line 32 in ee87291

_run_in_container_bash "nc ${NC_PARAMETERS} < /tmp/docker-mailserver-test/${TEMPLATE_FILE}.txt"

---

Chances are it's been banned before the test case can check (expects to first succeed with _send_email twice?), then:

docker-mailserver/test/tests/parallel/set1/spam_virus/fail2ban.bats

Lines 79 to 83 in ee87291

	# Checking that CONTAINER2_IP is banned in "${CONTAINER1_NAME}"
	CONTAINER2_IP=$(_get_container_ip "${CONTAINER2_NAME}")
	run _repeat_in_container_until_success_or_timeout 10 "${CONTAINER_NAME}" /bin/bash -c "fail2ban-client status postfix-sasl | grep -F '${CONTAINER2_IP}'"
	assert_success
	assert_output --partial 'Banned IP list:'

Generally we expect _send_mail to be successful when it's used, but this is a situation where it's non-deterministic, sometimes failing.

[georglauterbach]

Closing this as #3732 has been merged. Please re-open in case this issue still persists.