Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to update users password, made test and updated setup.sh #413

Merged
merged 3 commits into from
Dec 21, 2016

Conversation

Influencer
Copy link
Contributor

I'm interested in getting the functionality into master so I'm submitting a separate pull request for this item.

This pull is related to #383 and #357 .

A few variations as I had mentioned in #383 discussion:
I'm doing all of the searching and replacing in a single Sed statement. In testing I have found reliably no '%' special characters to be in the hashed password so I replaced the default separator with % instead.

I also included the .bak extension so the postfix_accounts.cf files can be rolled back in case of any error or issue.

I have updated setup.sh to include the new update function as well as included a separate test_update_password.bats as I was unsure if the norm was to add to the existing tests script. Also, not sure if I wrote the test correctly, it is my first time working with bats.

@Influencer
Copy link
Contributor Author

Not sure why the CI build failed? I have tested on my system and builds fine for me

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

Thanks @Influencer
Build hangs because of Clamav update.

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

I restarted the build.

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

I'm gonna change the config to avoid this issue.

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

@Influencer can you add an integration test using bats?
Thank you.

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

Your test needs to be included in test/tests.bats.
Otherwise it won't be triggered :-)

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

(later we'll have to refactor the test suite)

@ghost
Copy link

ghost commented Dec 21, 2016

I'll move the test into tests.bats. When you say missing integration test do you mean just move my test into the tests.bats or is the integration test a separate test that's needed?

@tomav
Copy link
Contributor

tomav commented Dec 21, 2016

Just move it to the tests.bats. (the label is more to know what is the issue status)

@ghost
Copy link

ghost commented Dec 21, 2016

Looks like I made the test fail by not removing the user after the test. Can you take a look and make sure that's the only thing failing

@tomav tomav merged commit 83c0095 into docker-mailserver:master Dec 21, 2016
This was referenced Dec 25, 2016
RichardFevrier pushed a commit to RichardFevrier/docker-mailserver that referenced this pull request Aug 26, 2019
…er-mailserver#413)

* Added script to update users password, made test and updated setup.sh

* Moved update password test to tests.bat

* Fixed test for update password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants