-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to update users password, made test and updated setup.sh #413
Conversation
Not sure why the CI build failed? I have tested on my system and builds fine for me |
Thanks @Influencer
I restarted the build. |
I'm gonna change the config to avoid this issue. |
@Influencer can you add an integration test using |
Your test needs to be included in |
(later we'll have to refactor the test suite) |
I'll move the test into tests.bats. When you say missing integration test do you mean just move my test into the tests.bats or is the integration test a separate test that's needed? |
Just move it to the |
Looks like I made the test fail by not removing the user after the test. Can you take a look and make sure that's the only thing failing |
…er-mailserver#413) * Added script to update users password, made test and updated setup.sh * Moved update password test to tests.bat * Fixed test for update password
I'm interested in getting the functionality into master so I'm submitting a separate pull request for this item.
This pull is related to #383 and #357 .
A few variations as I had mentioned in #383 discussion:
I'm doing all of the searching and replacing in a single Sed statement. In testing I have found reliably no '%' special characters to be in the hashed password so I replaced the default separator with % instead.
I also included the .bak extension so the postfix_accounts.cf files can be rolled back in case of any error or issue.
I have updated setup.sh to include the new update function as well as included a separate test_update_password.bats as I was unsure if the norm was to add to the existing tests script. Also, not sure if I wrote the test correctly, it is my first time working with bats.