Fix #443 - RIMAP support #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
tomav
reviewed
Jan 2, 2017
| @@ -0,0 +1,5 @@ | |||
| EHLO mail | |||
There was a problem hiding this comment.
Perhaps you should reuse the smpt auth (renaming the file to something more obvious, specifying the user perhaps). Because if we change a password, it should be done in both file (the probably look the same)
There was a problem hiding this comment.
Yes, reusing smtp-auth-login.txt makes sense.
Regarding checks of ENABLE_SASLAUTHD: perhaps we can drop that variable at all and just look at SASLAUTHD_MECHANISMS?
There was a problem hiding this comment.
That's an option. perhaps LDAP users may have an idea on that specific point.
But I'm currently refactoring tests and I can say that's not obvious when we look at the different combinations with these variables.
…map auth - remove sasl-imap-smtp-auth.txt again Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
|
Thanks @weo! |
RichardFevrier
pushed a commit
to RichardFevrier/docker-mailserver
that referenced
this pull request
Aug 26, 2019
* Add unit tests for docker-mailserver#443 (rimap auth) * Fix docker-mailserver#443 - configure rimap for saslauth * Fix docker-mailserver#443 - reuse smtp-auth-login.txt when testing rimap auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#443