Hostname override fixes for docker option --net=host in conjunction with OVERRIDE_HOSTNAME #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the hostname explicitly
|
Thanks @flole |
RichardFevrier
pushed a commit
to RichardFevrier/docker-mailserver
that referenced
this pull request
Aug 26, 2019
…ith OVERRIDE_HOSTNAME (docker-mailserver#517) * Fixed wrong mail headers when using OVERRIDE_HOSTNAME by setting the the hostname explicitly * Added tests and fixed hostname in dovecot conf * Added missing tests * Improved function naming and task notification message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that my emails contain the hostname of my docker host when I use the docker option
--net=hostwith the env-varOVERRIDE_HOSTNAME. That is because postfix, dovecot and opendmarc user thehostnamecommand to retrieve the name of host. Until now the hostname was only overwritten for amavis, but these changes will overwrite it for all mentioned services.