-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment variable for amavis subject tag #596
Environment variable for amavis subject tag #596
Conversation
Hi @elbracht, don't forget integration tests. |
@tomav do you have an idea why I can’t use a string as environment variable? If I use a number as environment variable in Works:
Don’t work:
|
Still 2 errors in this build. How can we move forward? |
@tomav I can’t use a string as environment variable to update the number (Makefile):
fixed value (start-mailserver.sh):
|
The error is here |
I have an error with
Let me know if it works for you. |
@tomav Nice! 👍 Now the local tests have been passed. |
Here we are! |
It's not clear for me how to disable the subject rewrite entirely. If SA_SPAM_SUBJECT is empty/undefined, it seems to default to ***SPAM***. I would like to keep my subject unchanged, because I'm moving spams to separate folder. |
@jholster maybe add a " " space in the variable might fit your needs. |
@johansmitsnl Tried that, didn't help, maybe the configuration parsers trims the lines? Anyway, sounds like hack. Can we additionally have SA_ENABLE_SPAM_SUBJECT_REWRITE boolean variable? I think it's very common case to move spam messages into separate spam folder. Once in a while I skim through my spams and move false positives to inbox/archive folder (to teach SpamAssassin). But the moved messages will have "SPAM" in subject line forever, which is kind of ugly. |
@jholster The following environment variable should solve your problem:
|
* Environment variable for spam subject tag * Add SA_SPAM_SUBJECT to readme * Add integration tests for spam subject tag * Fix overwrite environment variable in config file
Ref: #589
Environment variable to change the amavis tag
sa_spam_subject_tag
outside the container .