Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the decoders for amavis #677

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Expand the decoders for amavis #677

merged 1 commit into from
Aug 7, 2017

Conversation

johansmitsnl
Copy link
Contributor

See #659

@johansmitsnl johansmitsnl mentioned this pull request Jul 30, 2017
Closed
@Fmstrat
Copy link

Fmstrat commented Jul 31, 2017 •
edited

All of these aren't required, I would suggest trimming back. For instance, zip has an internal decoder, so there isn't a need to add "zip" as a package. The only decoders missing are:

mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .F
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .arc
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .cab
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .deb
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .doc
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .iso
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .jar
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .lha
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .lrz
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .lz4
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .lzma
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .lzo
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .rar
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .rpm
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .swf
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .xz
mail                 | Jul 20 15:38:51 mail amavis[1590]: No decoder for       .zoo

Edit: I should qualify this by "unless zip is handling one of the other extensions"

@johansmitsnl
Expand the decoders for amavis (Resolves: #659)
3bf7443 
Use the guidelines from Ubuntu and added some more.
Added a test to ensure the number of decoders are present.
Guideline: https://help.ubuntu.com/community/PostfixAmavisNew
@johansmitsnl
Copy link
Contributor Author

@Fmstrat I removed the zip, others are needed for the missing decoder list.

@Fmstrat
Copy link

Fmstrat commented Aug 4, 2017

Looks good to me! Hopefully we get a merge on this soon.

@johansmitsnl
Copy link
Contributor Author

@tomav @alinmear I have updated the PR with tests and they pass all now.
Can someone review and accept if ok?

@gutmensch
Copy link
Contributor

Well done, @johansmitsnl! I would also like to see this merged soon.

@tomav tomav merged commit 8b19d54 into docker-mailserver:master Aug 7, 2017
@tomav
Copy link
Contributor

tomav commented Aug 7, 2017

Thanks @johansmitsnl

@johansmitsnl johansmitsnl deleted the add-more-decoders-for-amavisd branch August 7, 2017 15:49
@johansmitsnl johansmitsnl mentioned this pull request Sep 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johansmitsnl @Fmstrat @gutmensch @tomav