Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver root mail #952

Merged
merged 5 commits into from
Apr 23, 2018

Conversation

crazystick
Copy link
Contributor

Deliver root mail to POSTMASTER_ADDRESS, fixes #947
If POSTMASTER_ADDRESS isn't defined, it defaults to postmaster@mydomain.com, and so you can also get it delivered by creating a virtual alias for postmaster@mydomain.com or via my favoured approach of using a regexp alias for postmaster@* (as seen in the test config).

One other thing - the tests were already failing for me before my change, as the email counts had increased by one, hence why I am increasing them by two in this PR.

Copy link
Contributor

@johansmitsnl johansmitsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to update the email count with 2 if you only send one email during the test?

@@ -1,2 +1,3 @@
/^test[0-9][0-9]*@localhost.localdomain/ user1@localhost.localdomain
/^bounce.*@.*/ external1@otherdomain.tld
/^postmaster@/ user1@localhost.localdomain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I mentioned in the PR body, the tests are failing before my changes as the counts are already wrong - I assume some earlier change broke these tests.

@17Halbe
Copy link
Contributor

17Halbe commented Apr 17, 2018

The last test (PR #942) succeeded with the current count. Any idea where the second mail is coming from? (Bounce, fail, something like that?)

@crazystick
Copy link
Contributor Author

crazystick commented Apr 17, 2018

You're right - I can't see any extra emails introduced in previous commits. When I comment out my extra mail in Makefile#252 then the build fails for me. Perhaps it's a test that was sending mail to postmaster@somewhere that was previously not delivered to any mailbox...

@crazystick
Copy link
Contributor Author

OK - I think figured it out. The extra email is the virus notification email which is sent to postmaster and previously was not delivered. Now it is thanks to the extra config in postfix-regexp.cf

@17Halbe
Copy link
Contributor

17Halbe commented Apr 18, 2018

So this was a bug? The mail was supposed to get delivered to postmaster?

@crazystick
Copy link
Contributor Author

Well more like an undocumented / untested feature! If you configured your postmaster address to get delivered, then you would get the email. It's unrelated to this PR, which does fix a bug (the bug is that mail to root is not delivered, and no configuration could fix that).

@johansmitsnl johansmitsnl merged commit ea848eb into docker-mailserver:master Apr 23, 2018
@crazystick crazystick deleted the deliver-root-mail branch April 23, 2018 23:35
johansmitsnl added a commit that referenced this pull request Jul 31, 2018
* Deliver root mail (Closes: #952)
* don't update permissions on non-existent file (Closes: #956)
* Update docker-configomat (Closes: #959)
* Support for detecting running container mount (Closes: #884)
* Report sender (Closes: #965)
  added REPORT_SENDER env variable to the container.
* Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (Closes: #979, #980)
* fix SASL domain (Closes: #892, #970)
* DOMAINNAME can fail to be set in postsrsd-wrapper.sh (Closes: #989)
johansmitsnl added a commit that referenced this pull request Jul 31, 2018
Release 6.1.0

* Deliver root mail (#952)
* don't update permissions on non-existent file (#956)
* Update docker-configomat (#959)
* Support for detecting running container mount (#884)
* Report sender (#965)
  added REPORT_SENDER env variable to the container.
* Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (#979, #980)
* fix SASL domain (#892, #970)
* DOMAINNAME can fail to be set in postsrsd-wrapper.sh (#989)
@polarathene polarathene mentioned this pull request Jan 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local System User Mail Delivery Issues
3 participants