added nat configuration

[d78ui98]

I have added NAT configuration to the dhcp server.

[dashohoxha]

I understand that you have copied this from some example, and in the case of example it may give a correct result, but not always.
Try this one which is safer: ip route | grep default | cut -d' ' -f5

[d78ui98]

okay. I will now prefer ip route over ifconfig.

[dashohoxha]

okay. I will now prefer ip route over ifconfig

It is not a matter of preference, your first implementation is not guaranteed to work in all the cases.

[dashohoxha]

Here -yq is not needed.

[d78ui98]

-yq flag is required to handle DEBIAN_FRONTEND variable.

[dashohoxha]

-yq flag is required to handle DEBIAN_FRONTEND variable.

Are you sure about this? Where did you find this information?

[d78ui98]

I can share the source - https://serverfault.com/a/227194

[dashohoxha]

Look up in the man page the meaning of -yq and then remove it.
You have spent me 1 our only for this, and it is not normal that I spend in the project as much time as you do.

[dashohoxha]

Here try something like this:
ip route | grep -v default | cut -d' ' -f3 | grep -v $INTERNET | head -1

[dashohoxha]

Are you sure we need this line with tftp? What does the documentation of dnsmasq say about it?

[d78ui98]

yes, the documentation says If dnsmasq is providing a TFTP service then only the filename is required to enable network booting.
Some comment on stackoverflow gave an explanation to this line and concluded that it would reduce time required for network boot.

[dashohoxha]

yes, the documentation says If dnsmasq is providing a TFTP service then only the filename is required to enable network booting.

We don't need TFTP service on the DHCP server.

Some comment on stackoverflow gave an explanation to this line and concluded that it would reduce time required for network boot.

You cannot trust all the comments on stackoverflow. Couldn't you find anything on the documentation of dnsmasq?

[dashohoxha]

We don't need TFTP service on the DHCP server.

Please remove this line and fix the configuration of dnsmasq.

[dashohoxha]

What happens if you remove (or comment out) this line?

[d78ui98]

This line is required to handle interactive post-install configuration. If we remove this we won't be able to handle that with our script. As a result we won't be able to install iptables-persistent

[dashohoxha]

This line is required to handle interactive post-install configuration. If we remove this we won't be able to handle that with our script. As a result we won't be able to install iptables-persistent

Have you tried this?

[d78ui98]

yes. I can share a screenshot of what happens if I remove that line. The provision script just freezes -

[dashohoxha]

yes. I can share a screenshot of what happens if I remove that line.

If I try to remove it and there is no problem, then you are going to have problems. OK?

[d78ui98]

Sure. I can make it easy for you. I have created a video which has both cases(line commented and line not commented) https://youtu.be/WQHwKu9ebYA

[dashohoxha]

Ok, do it like this:

DEBIAN_FRONTEND=noninteractive apt --yes install iptables-persistent

[dashohoxha]

You can move this line after changing the configuration (or place the configuration change above it), just to keep them together.

[dashohoxha]

I am not sure that the default configuration of dnsmasq is correct (without you customizing it).
But you can merge this branch if you wish and fix this problem later, if needed.