You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi. Thanks very much for making this GitHub Action!
I'd like to suggest that in the dockerfile option the text
Name of the Dockerfile
be changed to
Path to the Dockerfile relative to path.
When I first read the docs I got confused by the use of "path" and "name" (instead of "context" and "path") and for a directory that structure that is structured with
$ tree
.
├── other_files_needed_for_build
├── docker
│ └── Dockerfile
attempted to use
- name: Build and Publish to Registryuses: docker/build-push-action@v1with:
username: ${{ secrets.DOCKER_USERNAME }}password: ${{ secrets.DOCKER_PASSWORD }}repository: org/repo-namepath: dockerdockerfile: Dockerfile
instead of the following (correct)
- name: Build and Publish to Registryuses: docker/build-push-action@v1with:
username: ${{ secrets.DOCKER_USERNAME }}password: ${{ secrets.DOCKER_PASSWORD }}repository: org/repo-namedockerfile: docker/Dockerfile
I think the use of "path" would be more clear than "name". If you agree with me I have a branch with this change on my fork that I can open a PR here on (though telling me to do so might involve more typing).
The text was updated successfully, but these errors were encountered:
Hi. Thanks very much for making this GitHub Action!
I'd like to suggest that in the
dockerfile
option the textbe changed to
When I first read the docs I got confused by the use of "path" and "name" (instead of "context" and "path") and for a directory that structure that is structured with
attempted to use
instead of the following (correct)
I think the use of "path" would be more clear than "name". If you agree with me I have a branch with this change on my fork that I can open a PR here on (though telling me to do so might involve more typing).
The text was updated successfully, but these errors were encountered: