Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using BuildKit #32

Closed
garethr opened this issue Apr 18, 2020 · 3 comments
Closed

Default to using BuildKit #32

garethr opened this issue Apr 18, 2020 · 3 comments
Milestone

Comments

@garethr
Copy link

garethr commented Apr 18, 2020

I'm finding myself always needing to remember to add the following to my actions:

env:
        DOCKER_BUILDKIT: 1

I wonder if this should be a first-class part of the interface, rather than needing to know the environment variable? I also wonder if this should default to using BuildKit?

@zappy-shu
Copy link
Contributor

zappy-shu commented Apr 22, 2020

Hi @garethr this is something I'd like to do as well. It shouldn't be too difficult to implement.
@nebuk89 any thoughts?

@crazy-max
Copy link
Member

Version 2 has been merged to the main branch and is therefore available via uses: docker/build-push-action@v2 (mutable tag).

As a reminder, this new version changes drastically and works with 3 new actions (login, setup-buildx and setup-qemu) that we have created. Many usage examples have been added to handle most use cases.

And it should fix this current issue. Don't hesitate if you have any questions.

@theogravity
Copy link

With v2, do I need to use the DOCKER_BUILDKIT env variable at all? Not clear from the readme and the discussion thread here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants