Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dockerui context detection #1733

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Use dockerui context detection #1733

merged 2 commits into from
Apr 14, 2023

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Apr 12, 2023

⬆️ Follow-up to moby/buildkit#3769.

See #1710 (comment):

We probably also want to update detectGitContext to align with buildkit, but we should do that by exposing that method to be public first (will open a buildkit-side PR to do that).

@jedevc
vendor: update buildkit to master@333ee9158128
62a2152 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc requested a review from crazy-max April 12, 2023 09:59
@jedevc
bake: update ReadRemoteFiles to use buildkit api
871f865 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the use-dockerui-context-detection branch from 5a9745c to 871f865 Compare April 12, 2023 10:15
@jedevc jedevc merged commit 7d35a3b into docker:master Apr 14, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jedevc @crazy-max