commands: release the file lock before attempting to boot during create #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the boot command hung or took a long time, it blocked any read operations (such as `buildx ls`). When the boot happens, we no longer need to hold the file lock so we can release it. Releasing multiple times is legal and causes whichever release that is second to be a no-op so the defer is kept to ensure the lock is released even when an error condition happens. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
crazy-max
approved these changes
Sep 30, 2023
jedevc
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the boot command hung or took a long time, it blocked any read
operations (such as
buildx ls).When the boot happens, we no longer need to hold the file lock so we can
release it. Releasing multiple times is legal and causes whichever
release that is second to be a no-op so the defer is kept to ensure the
lock is released even when an error condition happens.
Fixes #2062.