build: handle push/load shorthands for multi exporters #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
multi-load-push
branch
5 times, most recently
from
7189b43
to
8763b12
Compare
crazy-max
commented
Mar 1, 2024
crazy-max
force-pushed
the
multi-load-push
branch
from
8763b12
to
9197a9b
Compare
tonistiigi
reviewed
Mar 4, 2024
crazy-max
force-pushed
the
multi-load-push
branch
4 times, most recently
from
9197a9b
to
c42c903
Compare
tonistiigi
reviewed
Mar 5, 2024
controller/build/build.go
Outdated
| @@ -99,36 +99,52 @@ func RunBuild(ctx context.Context, dockerCli command.Cli, in controllerapi.Build | |||
| return nil, nil, err | |||
| } | |||
| if in.ExportPush { | |||
| if in.ExportLoad { | |||
| return nil, nil, errors.Errorf("push and load may not be set together at the moment") | |||
| } | |||
| if len(outputs) == 0 { | |||
There was a problem hiding this comment.
This case is not needed anymore. Else case behaves same way if len(outputs) == 0. Same for docker.
There was a problem hiding this comment.
Ah right, we are already checking if push/load is used.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
multi-load-push
branch
from
c42c903
to
9a2536d
Compare
tonistiigi
approved these changes
Mar 5, 2024
3 tasks
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes docker/build-push-action#727
We forgot to handle
pushandloadshorthands in #2290.Keeping this one in draft while I'm working on integration tests.EDIT: Argh GitHub is broken https://www.githubstatus.com/incidents/wcl1sw4mzg60