Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove "experimental" checks, as they may be redundant #5140

Open
thaJeztah opened this issue Jun 11, 2024 · 0 comments
Open

CI: remove "experimental" checks, as they may be redundant #5140

thaJeztah opened this issue Jun 11, 2024 · 0 comments

Comments

@thaJeztah
Copy link
Member

Description

While working on #5139, I noticed that CI was green even if we didn't enable experimental on the daemon.

I was curious how the experimental and non-experimental e2e tests differed, and after a cursory glance, it may be only for a single test;

environment.SkipIfNotExperimentalDaemon(t)

If that's correct, then it would mean we run all e2e tests twice, but only for a single test; we can cut the number of checks in half if we don't do so;

  • Always enable experimental on the daemon (we already do so!)
  • Run the tests and let the "experimental" one be skipped
  • Rejoice!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant