only consider containers with config_hash labels (i.e, created by compose) #10317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10317 +/- ##
==========================================
+ Coverage 73.89% 74.18% +0.28%
==========================================
Files 2 2
Lines 272 275 +3
==========================================
+ Hits 201 204 +3
Misses 60 60
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
image_labels
branch
from
c0fc77a
to
eaf2f15
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
laurazard
approved these changes
Feb 27, 2023
milas
approved these changes
Feb 27, 2023
glours
approved these changes
Feb 28, 2023
ndeloof
force-pushed
the
image_labels
branch
from
eaf2f15
to
8f78e76
Compare
…pose) Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As
compose buildsets a fewcom.docker.composelabels we need to distinguish container created by compose and not by another command.Related issue
close #10314
(not mandatory) A picture of a cute animal, if possible in relation to what you did