Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run restart support #10339

Merged
merged 1 commit into from Mar 2, 2023
Merged

Dry run restart support #10339

merged 1 commit into from Mar 2, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Mar 1, 2023

What I did
Add dry run support to restart command

Related issue
Need #10338 to be merged first
https://docker.atlassian.net/browse/ENV-65

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours self-assigned this Mar 1, 2023
@glours glours requested review from milas and ndeloof and removed request for milas March 1, 2023 17:28
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.09 🎉

Comparison is base (0a5ece7) 73.09% compared to head (9c2493c) 74.18%.

❗ Current head 9c2493c differs from pull request most recent head 167c6a8. Consider uploading reports for the commit 167c6a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10339      +/-   ##
==========================================
+ Coverage   73.09%   74.18%   +1.09%     
==========================================
  Files           2        2              
  Lines         275      275              
==========================================
+ Hits          201      204       +3     
+ Misses         62       60       -2     
+ Partials       12       11       -1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 72.48% <0.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours enabled auto-merge March 2, 2023 09:16
@glours glours merged commit c4b47fe into docker:v2 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants