Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logging configuration under logging key #2503

Closed
aanand opened this issue Dec 4, 2015 · 2 comments
Closed

Move logging configuration under logging key #2503

aanand opened this issue Dec 4, 2015 · 2 comments

Comments

@aanand
Copy link

aanand commented Dec 4, 2015

Right now we have log_driver and log_opt. It'd be cleaner to have them both under a logging key:

logging:
  driver: syslog
  options:
    syslog-address: "tcp://192.168.0.42:123"

An additional advantage: overriding a service's logging option would be cleaner, as you only have to override a single key (you're never going to want to override log_driver but not log_opt, because options are driver-specific).

@dbonev
Copy link

dbonev commented Dec 19, 2015

#dibs

@aanand
Copy link
Author

aanand commented Jan 12, 2016

Closed by #2626

@aanand aanand closed this as completed Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants