Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker push fails with 'error parsing HTTP 4XX response body: unexpected end of JSON input: ""' if any error is returned by the server #2649

Open
BenLubar opened this issue Jul 18, 2018 · 2 comments
Labels

Comments

@BenLubar
Copy link

This code doesn't retry the request as a GET request if an error is returned, so the body of the response is always empty:

https://github.com/docker/distribution/blob/749f6afb4572201e3c37325d0ffedb6f32be8950/registry/client/repository.go#L371-L392

@Jamstah
Copy link
Collaborator

Jamstah commented Nov 11, 2022

This is a client issue and the client in this repo is not maintained. Should this be closed?

@milosgajdos
Copy link
Member

Either we close it or we do something with the client, but that'd require proper TLC; I'd leave it open but I'll take it outta 3.0 Milestone....that being said, I'm not entirely sold on the idea of adding retries to the default client.

@milosgajdos milosgajdos removed this from the Registry/3.0.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants