Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxes filesystem driver permissions to 0777 (dirs) and 0666 (files) #1304

Merged
merged 1 commit into from
Dec 30, 2015

Conversation

BrianBland
Copy link
Contributor

Leaves any further permissions restrictions to the process umask

Signed-off-by: Brian Bland brian.bland@docker.com

Addresses #1295

Leaves any further permissions restrictions to the process umask

Signed-off-by: Brian Bland <brian.bland@docker.com>
@codecov-io
Copy link

Current coverage is 57.52%

Merging #1304 into master will decrease coverage by -0.03% as of f19deba

@@            master   #1304   diff @@
======================================
  Files          116     116       
  Stmts        10468   10468       
  Branches       718     719     +1
  Methods          0       0       
======================================
- Hit           6025    6022     -3
- Partial        718     719     +1
- Missed        3725    3727     +2

Review entire Coverage Diff as of f19deba


Uncovered Suggestions

  1. +0.31% via ...ge/driver/gcs/gcs.go#185...216
  2. +0.31% via ...ge/driver/gcs/gcs.go#104...135
  3. +0.23% via ...ge/driver/gcs/gcs.go#469...492
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@stevvooe
Copy link
Collaborator

@BrianBland Do we have a test for this?

@stevvooe
Copy link
Collaborator

@BrianBland NM. LGTM.

stevvooe added a commit that referenced this pull request Dec 30, 2015
Relaxes filesystem driver permissions to 0777 (dirs) and 0666 (files)
@stevvooe stevvooe merged commit 00b983b into distribution:master Dec 30, 2015
@BrianBland BrianBland deleted the fsDriverRelaxedPermissions branch January 5, 2016 21:51
stefannica added a commit to stefannica/distribution that referenced this pull request Jul 16, 2020
There was a previous PR relaxing the filsystem driver permissions
for files and folders to 0666 and 0777 respectively [1][2], but it was
incomplete. This is required to get the registry to honor the umask
value.

[1] distribution#1304
[2] distribution#1295

Signed-off-by: Stefan Nica <snica@suse.com>
thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Apr 22, 2021
…ermissions

Relaxes filesystem driver permissions to 0777 (dirs) and 0666 (files)
thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Jan 19, 2022
…ermissions

Relaxes filesystem driver permissions to 0777 (dirs) and 0666 (files)
dylanrhysscott pushed a commit to digitalocean/docker-distribution that referenced this pull request Jan 5, 2023
There was a previous PR relaxing the filsystem driver permissions
for files and folders to 0666 and 0777 respectively [1][2], but it was
incomplete. This is required to get the registry to honor the umask
value.

[1] distribution#1304
[2] distribution#1295

Signed-off-by: Stefan Nica <snica@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants