Add tests for splithostname on normalized values #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
|
LGTM |
Current coverage is 51.10% (diff: 100%)@@ master #2132 diff @@
==========================================
Files 125 125
Lines 11434 11434
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6987 5843 -1144
- Misses 3559 4845 +1286
+ Partials 888 746 -142
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate deterministic parsing of names using normalization and the resulting domain and path.
Replaces #1777