registy/handlers: move images to manifests #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 51.11% (diff: 100%)@@ master #2134 diff @@
==========================================
Files 125 125
Lines 11432 11432
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6987 5843 -1144
- Misses 3557 4843 +1286
+ Partials 888 746 -142
|
dmcgowan
reviewed
Jan 11, 2017
| @@ -26,45 +26,45 @@ const ( | |||
| defaultOS = "linux" | |||
| ) | |||
|
|
|||
| // imageManifestDispatcher takes the request context and builds the | |||
| // manifestDispatcher takes the request context and builds the | |||
| // appropriate handler for handling image manifest requests. | |||
There was a problem hiding this comment.
"handling manifest requests"
dmcgowan
reviewed
Jan 11, 2017
| @@ -231,8 +231,8 @@ func etagMatch(r *http.Request, etag string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| // PutImageManifest validates and stores an image in the registry. | |||
| func (imh *imageManifestHandler) PutImageManifest(w http.ResponseWriter, r *http.Request) { | |||
| // PutManifest validates and stores an image in the registry. | |||
|
A couple lingering comment references, then LGTM |
Once upon a time, we referred to manifests and images interchangably. That simple past is no more. As we grow, we update our nomenclature and so follows our code. Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
images-are-manifests
branch
from
2cf1f0e
to
c91a68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, we referred to manifests and images interchangably.
That simple past is no more. As we grow, we update our nomenclature and
so follows our code.
Signed-off-by: Stephen J Day stephen.day@docker.com