This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.06] backport (cli) Don't prune volumes on docker system prune #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volumes tend to carry important data and pruning them on `docker system prune` can easily cause unwanted data loss. Let's play it safe and not prune volumes on `system prune` by default, and instead provide an option. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 37fd6128dc268b885f070b6d89a72e73d2eacec8) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Harald Albers <github@albersweb.de>(cherry picked from commit 849b0e96a01e657f4be4c35e7fa4bce2736dc376) Conflicts: components/cli/cli/command/system/prune.go Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
thaJeztah
approved these changes
Jul 12, 2017
|
LGTM |
docker-jenkins
pushed a commit
that referenced
this pull request
May 23, 2018
Set GO_VERSION with a build arg Upstream-commit: 05cbbc2 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 15, 2018
…tests [18.09 backport] Cleanup volume integration tests Upstream-commit: 4980e48e4b2c34288cf3f1265db6eff6713b487c Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
[17.06] backport (cli) Don't prune volumes on docker system prune
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Set GO_VERSION with a build arg
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from upstream PRs:
docker system prunedocker/cli#118 Don't prune volumes ondocker system pruneWith cherry-pick docker/cli@37fd612 and docker/cli@849b0e9:
Conflict with
components/cli/cli/command/system/prune.gobut was able to resolve by taking the cherry-pick's change set.