Add sysctl support for docker swarm services #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
requested changes
Aug 11, 2022
There was a problem hiding this comment.
Thanks for the PR!
The changes look good other than the lint issues - you can run make flake8 locally to see them and get them fixed, then re-push and CI should re-run and give you a pass.
However, please be sure to fetch latest and merge/rebase from main first! There were a couple issues that snuck through for a bit there, so you'll run into trouble otherwise 😓
Signed-off-by: Quentin Mathorel <quentin.mathorel@outlook.fr>
Signed-off-by: Quentin Mathorel <quentin.mathorel@outlook.fr>
|
Hello and thank you @milas for the review! I rebased and linted as requested. |
milas
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #2907