Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker docs still use (soft-deprecated) graph instead of data-root #5922

Closed
JoshuaSCochrane opened this issue Feb 5, 2018 · 3 comments
Closed
Labels
area/engine Issue affects Docker engine/daemon lifecycle/locked

Comments

@JoshuaSCochrane
Copy link

The use of graph has been soft-deprecated since moby/moby#28696 in favor of the more descriptive data-root, but the docs still refer to graph (apparently throughout). I only learned about data-root when I saw a comment on a GH discussion...

File: config/daemon/systemd.md, CC @johndmulhausen

@gbarr01 gbarr01 added the area/engine Issue affects Docker engine/daemon label Feb 5, 2018
@mdlinville mdlinville self-assigned this Feb 8, 2018
@JoshuaSCochrane
Copy link
Author

@mistyhacks Thanks for removing specifically --graph, but config references to just "graph" and doc references to 'graph' should also be replaced. I suppose I could check this out and create the PR in order to grep the codebase for 'graph', but... Sorry I wasn't more descriptive in the original request, but I figured a 'grep' of the docs codebase would reveal more instances.

A few examples I see when searching the 'Docs' online:

  • Control Docker with systemd/Runtime directory and storage driver uses "graph" in the daemon.json example
  • Daemon CLI (dockerd) - Edge page has a few references:
    • These aren't direct config examples, and I'm not 100% sure if the term 'graph' (in this `/var/lib/docker' usage) is deprecated in favor of 'data root' (or just the setting), so I'll defer to your judgement, but they look applicable to me
    • Daemon storage-driver references 'devicemapper graph location – typically /var/lib/docker/devicemapper'
    • ZFS Options references 'where docker graph (/var/lib/docker) is located'
  • There may be other examples, or maybe not - I'm not sure

Note that not all references to 'graph' may need to be replaced - I think things referencing 'graph drivers' may be ok. Not sure.

@nickbreen
Copy link

https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-storage-driver still refers to a -g option for dockerd too.

Confusingly without any explanation of what it is! These references should(?) be updated to --data-root too.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/engine Issue affects Docker engine/daemon lifecycle/locked
Projects
None yet
Development

No branches or pull requests

5 participants