Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial screen shots have wrong port number #8534

Closed
michaelthoward opened this issue Mar 26, 2019 · 6 comments
Closed

tutorial screen shots have wrong port number #8534

michaelthoward opened this issue Mar 26, 2019 · 6 comments

Comments

@michaelthoward
Copy link

michaelthoward commented Mar 26, 2019

File: get-started/part3.md

In parts 3 and 4 of tutorial, screen shots shows default http port 80, but should explicitly show port 4000.
Note that curl command in text explicitly says http://localhost:4000

image

This caused a problem for me when I hit Tutorial Part 4 because while googling for a solution I found #4608 and got confused.

Note that there is no mention of port 4000 in the text nor in the screen shot

image

yet port 4000 is required

image

@michaelthoward michaelthoward changed the title tutorial part 3 screen shot has wrong port number tutorial screen shots have wrong port number Mar 27, 2019
@michaelthoward
Copy link
Author

This port confusion problem is pervasive.
In part 3, the docker-compose.yml file shows using port 4000 and the text reinforces that.

image

Yet, the Recap and cheat sheet video shows using port 80

image

@michaelthoward
Copy link
Author

By the time you get to Part 5 everything assumes port 80.
This is a source of confusion for newbies who are struggling to learn about port mapping.
The tutorial is where they/we start, and if it is confusing then that does not build confidence.

@abuuzayr
Copy link

thanks @michaelthoward .. however since this is a swarm I am expecting to be able to access the app via the 2nd VM's IP as well, even with port. However I can only get a response from the first VM:

Screen Shot 2019-05-23 at 12 32 41 PM

Is it working for you?

@abuuzayr
Copy link

Ok wow. this is strange. I just tried it and its working without the ports:

Screen Shot 2019-05-23 at 12 35 46 PM

The ports in my docker compose is set to 80:80:

Screen Shot 2019-05-23 at 12 35 59 PM

@Dawn-Wood
Copy link
Contributor

Hi everyone!! Thanks for the feedback!! We just updated the whole Get Started guide to align with current best practices. As a bonus, we also removed the steps that you allude to.
Love to hear your feedback on the updated guide.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants