Compose V2.0.0 #13474
Closed
Compose V2.0.0 #13474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: b318028 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6141e276cf0cbf0008291dde 😎 Browse the preview: https://deploy-preview-13474--docsdocker.netlify.app |
ndeloof
force-pushed
the
compose_v2_GA
branch
4 times, most recently
from
24a624c
to
3c376b1
Compare
mat007
reviewed
Sep 8, 2021
ndeloof
force-pushed
the
compose_v2_GA
branch
5 times, most recently
from
d112883
to
4dc7d44
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
compose_v2_GA
branch
from
4dc7d44
to
ff501e3
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
compose_v2_GA
branch
from
ff501e3
to
7a86909
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
| @@ -95,114 +93,62 @@ on Microsoft Windows Server and want to install Docker Compose. | |||
| Invoke-WebRequest "https://github.com/docker/compose/releases/download/{{site.compose_version}}/docker-compose-Windows-x86_64.exe" -UseBasicParsing -OutFile $Env:ProgramFiles\Docker\docker-compose.exe | |||
There was a problem hiding this comment.
Suggested change
| Invoke-WebRequest "https://github.com/docker/compose/releases/download/{{site.compose_version}}/docker-compose-Windows-x86_64.exe" -UseBasicParsing -OutFile $Env:ProgramFiles\Docker\docker-compose.exe | |
| mkdir $Env:ProgramFiles\Docker\cli-plugins | |
| Invoke-WebRequest "https://github.com/docker/compose/releases/download/v{{site.compose_version}}/docker-compose-windows-amd64.exe" -UseBasicParsing -OutFile $Env:ProgramFiles\Docker\cli-plugins\docker-compose.exe |
| @@ -95,114 +93,62 @@ on Microsoft Windows Server and want to install Docker Compose. | |||
| Invoke-WebRequest "https://github.com/docker/compose/releases/download/{{site.compose_version}}/docker-compose-Windows-x86_64.exe" -UseBasicParsing -OutFile $Env:ProgramFiles\Docker\docker-compose.exe | |||
| ``` | |||
|
|
|||
| **Note**: On Windows Server 2019, you can add the Compose executable to `$Env:ProgramFiles\Docker`. Because this directory is registered in the system `PATH`, you can run the `docker-compose --version` command on the subsequent step with no additional configuration. | |||
| **Note**: On Windows Server 2019, you can add the Compose executable to `$Env:ProgramFiles\Docker`. Because this directory is registered in the system `PATH`, you can run the `docker compose --version` command on the subsequent step with no additional configuration. | |||
There was a problem hiding this comment.
Suggested change
| **Note**: On Windows Server 2019, you can add the Compose executable to `$Env:ProgramFiles\Docker`. Because this directory is registered in the system `PATH`, you can run the `docker compose --version` command on the subsequent step with no additional configuration. | |
| **Note**: On Windows Server 2019, you can add the Compose executable to `$Env:ProgramFiles\Docker\cli-plugins`. Because this directory is used for Docker CLI plugins, you can run the `docker compose --version` command on the subsequent step with no additional configuration. |
scop
reviewed
Oct 8, 2021
| - Blank lines are ignored. | ||
| - Multi-line values can be wrapped using double quotes. | ||
| - Values can be wrapped by single or double quotes, which will be removed from actual value | ||
| - Variables defined by dolar sign `$` inside value are substitued, unless value is wrapped by single quotes |
There was a problem hiding this comment.
Suggested change
| - Variables defined by dolar sign `$` inside value are substitued, unless value is wrapped by single quotes | |
| - Variables defined by dollar sign `$` inside value are substituted, unless value is wrapped by single quotes |
Varriount
reviewed
Nov 20, 2021
|
|
||
| - Compose expects each line in an `env` file to be in `VAR=VAL` format. | ||
| - Lines beginning with `#` are processed as comments and ignored. | ||
| - Blank lines are ignored. | ||
| - There is no special handling of quotation marks. This means that | ||
| **they are part of the VAL**. | ||
|
|
||
| ### Compose 2.x | ||
|
|
||
| Compose V2 adopt the [Ruby-style dotEnv file syntax](https://github.com/bkeepers/dotenv#usage), |
There was a problem hiding this comment.
Suggested change
| Compose V2 adopt the [Ruby-style dotEnv file syntax](https://github.com/bkeepers/dotenv#usage), | |
| Compose V2 adopts the [Ruby-style dotenv file syntax](https://github.com/bkeepers/dotenv#usage), |
Varriount
reviewed
Nov 20, 2021
| @@ -20,14 +20,50 @@ The project directory is specified by the order of precedence: | |||
|
|
|||
| ## Syntax rules | |||
|
|
|||
| The following syntax rules apply to the `.env` file: | |||
| The "dotEnv" file format is a _de facto_ convention, not a standard with no clear specification, | |||
There was a problem hiding this comment.
Suggested change
| The "dotEnv" file format is a _de facto_ convention, not a standard with no clear specification, | |
| The "dotenv" file format is a _de facto_ convention, not a standard with no clear specification, |
craig-osterhout
added
the
area/compose
|
Closing this PR as the updates are merged and published through other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update documentation as Compose V2 has been released
Unreleased project version (optional)
This change only applies once github.com/docker/compose has released v2.0.0