17.06: improve the Docker for Mac networking workaround #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlinville
suggested changes
May 10, 2017
|
I tried changing the base but you need to rebase it locally. |
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
|
@mstanleyjones I've rebased onto |
mdlinville
approved these changes
May 19, 2017
mdlinville
pushed a commit
that referenced
this pull request
Jun 1, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
mdlinville
pushed a commit
that referenced
this pull request
Jun 5, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
mdlinville
pushed a commit
that referenced
this pull request
Jun 16, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
mdlinville
pushed a commit
that referenced
this pull request
Jun 20, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
mdlinville
pushed a commit
that referenced
this pull request
Jun 26, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
mdlinville
pushed a commit
that referenced
this pull request
Jun 28, 2017
Rather than manually creating a custom IP alas on the host, a container can connect to the host by resolving the DNS name `docker.for.mac.localhost`. Signed-off-by: David Scott <dave.scott@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In Docker for Mac 17.05 and earlier, there is no easy way for a container to contact a service running on the host (such as a local HTTP proxy) without knowing the host's IP addresses. The workaround in the docs is to add a new IP alias and use that.
In the upcoming 17.06 release of Docker for Mac, there is a special internal DNS name
docker.for.mac.localhost. This patch replaces the IP alias workaround with a note about the new DNS name.Unreleased project version (optional)
This only applies to Docker for Mac 17.06.