Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix menu overflow #5574

Merged
merged 21 commits into from Jan 18, 2018
Merged

WIP: Fix menu overflow #5574

merged 21 commits into from Jan 18, 2018

Conversation

jsouth
Copy link
Contributor

@jsouth jsouth commented Dec 20, 2017

Fixes #5511
Fixes #5207

However, I would like to fine tune the actions on viewport rescaling a bit more.

More to come :)

@jsouth
Copy link
Contributor Author

jsouth commented Dec 20, 2017

@johndmulhausen

  • update -
    Still noticing issues in some browsers. Needs further refinement.

@mdlinville mdlinville changed the title Fix menu overflow WIP: Fix menu overflow Dec 20, 2017
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few things:

  • The alignment of the search box on a full-width browser on the very front page seems weird. Shouldn't it left-align with the left-hand nav?

  • If you switch to another tab (like Product Manuals) and then back to the front page, you lose the search box entirely sometimes. This happened to me at least once but I couldn't reliably replicate it.

  • From 991-1024 px wide I don't have the archive drop-down at all even though I haven't switched into "mobile mode" so I don't have the hamburger either.

  • There is no way to select archive versions at all in the mobile view, unless you know that they are available at the bottom of the left nav. Maybe this is OK.

  • Around 785px and smaller, parts of the top nav (Guides / Product Manuals / Glossary etc) start disappearing and are not accessible in any way.

@jsouth
Copy link
Contributor Author

jsouth commented Dec 20, 2017

@mistyhacks - Thank you for the above comments/details!

Going to take another crack at this 🌟

@mdlinville
Copy link

1025px - 1141px is weird because the top bar is still small (not the hero one) but its background is transitioning like the hero one does. I think this is not what we want. @jsouth

@mdlinville
Copy link

@jsouth looks like you need to rebase on msater.

@jsouth
Copy link
Contributor Author

jsouth commented Jan 16, 2018

menu

Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! 993-1000PX has no hamburger menu and also no drop-down version selector. I think the hamburger should probaby start at 1000 and go down. WDYT?

@jsouth
Copy link
Contributor Author

jsouth commented Jan 18, 2018

@mistyhacks - The hamburger menu is utilizing the default bootstrap breakpoints. We can override, but need to double check to be sure it won't effect anything negatively. will circle back!

@jsouth
Copy link
Contributor Author

jsouth commented Jan 18, 2018

@mistyhacks - Would it be possible to merge what we have, and i"ll do some follow up fixes?
The current PR addresses the breakage for the version selector, and would like to get this out soon if possible.

please advise :)

@mdlinville
Copy link

Sure, that sounds fine. I'm not sure why the hamburger menu is not behaving if it is just using the default Bootstrap breakpoints. I would prefer for us not to have to override the Bootstrap defaults in anyway. We can debug that 7-pixel gap in a follow-up!

@mdlinville mdlinville merged commit c02ffd6 into docker:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants