Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker for Mac: add page on disk space #6944

Merged
merged 3 commits into from Feb 6, 2019
Merged

Conversation

djs55
Copy link
Contributor

@djs55 djs55 commented Jun 26, 2018

Proposed changes

The disk space usage of Docker on Mac has been difficult to manage and has confused lots of people, see

docker/for-mac#371

This patch adds a top-level section to the Docker for Mac docs alongside networking which explains

  • where the space has gone
  • how to reclaim some of it

In future I'd like to add more about why some systems use Docker.raw and some Docker.qcow2 but we're in a transitional state at the moment. It'll be simpler to explain after the next stable version has been released.

Related issues (optional)

Related to docker/for-mac#371

The disk space usage of Docker on Mac has been difficult to manage
and has confused lots of people, see

docker/for-mac#371

This patch adds a top-level section to the Docker for Mac docs
alongside networking which explains

- where the space has gone
- how to reclaim some of it

In future I'd like to add more about why some systems use `Docker.raw`
and some `Docker.qcow2` but we're in a transitional state at the moment.
It'll be simpler to explain after the next stable version has been
released.

Signed-off-by: David Scott <dave.scott@docker.com>
@gondalez
Copy link

Thanks for your work! I think this will help a lot.

Do you think it would be useful to communicate this in the docker mac UI?
Something like this on the disk tab (the learn more link would lead to the docs in this PR):

optimal
your system supports raw mode which is optimal for docker mac.
[learn more]

compatibility mode ⚠️
your version of macos does not support raw mode so docker mac is using qcow.
upgrade to the latest macos to make docker faster.
[learn more]

compatibility mode ⚠️
your image is on a disk not formatted as APFS so docker mac is using qcow.
put your image on an APFS disk or upgrade your hardware to make docker faster.
[learn more]

compatibility mode ⚠️
your version of macos supports raw mode but you are running qcow from a prior install.
[remove all data] to make docker faster.
[learn more]

@djs55
Copy link
Contributor Author

djs55 commented Jun 27, 2018

@gondalez I think that's a good idea. What do you think, @gtardif ?

@paigehargrave
Copy link
Contributor

@gtardif - PTAL - thank you!

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick first glance; left some notes

```
then list containers with:
```bash
$ docker container ls -a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to use docker system df instead of checking only containers and images; doing so also shows how much the actual use is, and how much is reclaimable https://docs.docker.com/engine/reference/commandline/system_df/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. Thank you for the input!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks fine to me!


Note that other tools may display the space usage of the file incorrectly.

## If the file is too big
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention the actual vs virtual size of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good idea. It's mentioned further down but it would be good to bring it nearer the top since it's bound to be a frequent source of confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaJeztah @djs55 - Thank you both for the input! Please see my latest updates to see if this is what you are looking for and if more is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me!

@paigehargrave
Copy link
Contributor

@thaJeztah @djs55 - Thank you both for the input! Please see my latest updates to see if this is what you are looking for and if more is needed.

@GordonTheTurtle
Copy link

GordonTheTurtle commented Jan 20, 2019

Deploy preview for docsdocker ready!

Built with commit 9aa8abe

https://deploy-preview-6944--docsdocker.netlify.com

@ghost ghost self-requested a review January 22, 2019 16:39
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@paigehargrave
Copy link
Contributor

Merging this - will open up a separate PR for TOC update. Thank you @djs55 and @thaJeztah !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants