Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose file reference doc references .env file support #3654

Closed
dnephin opened this issue Jun 19, 2017 · 7 comments
Closed

Compose file reference doc references .env file support #3654

dnephin opened this issue Jun 19, 2017 · 7 comments
Assignees
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary lifecycle/locked

Comments

@dnephin
Copy link
Contributor

dnephin commented Jun 19, 2017

See moby/moby#29133 (comment)

https://docs.docker.com/compose/compose-file/#variable-substitution

We should either remove the reference to .env from this document or clarify that it's only a docker-compose feature.

@dnephin dnephin changed the title Compose file reference references .env file support Compose file reference doc references .env file support Jun 19, 2017
@bastiaanb
Copy link
Contributor

@dnephin : or create feature parity by adding a parameter to docker stack create to specify an env file?
I understand docker stack to be a replacement to docker-compose, but it is not?
Thanks!

@dnephin
Copy link
Contributor Author

dnephin commented Jun 20, 2017

Even if we were to add .env file support I don't think it's correct to document it here. This file should be a reference for the format. At most we should link to another page.

I understand docker stack to be a replacement to docker-compose, but it is not?

Maybe eventually, but certainly not now. They support the same format (with a few exceptions) but the commands are designed for different use cases. docker-compose is designed for development and testing workflows, docker stack deploy is designed for more general use cases (including production). The trade offs are a bit different. One is not a drop-in replacement for the other.

@thaJeztah
Copy link
Member

ping @londoncalling

@fedaykin
Copy link

@dnephin I believe this is where docker-compose.yml syntax is documented, both for Compose (docker-compose) and for docker stack deploy. Throughout this page is documentation specifying which features and what syntax is available via either docker-compose or docker stack deploy. For the '.env' feature, one is simply led to conclude that it's available for both, and I'm of the opinion it should be.

@dperetti
Copy link

New users first learn about docker-compose.yml (the file) when they experiment with docker-compose (the command).
Then they get into to swarm stuff, and it's still referred to as a docker-compose.yml file.
The documentation should maybe use a different name, like docker stack deploy -c docker-swarm.yml.

@londoncalling
Copy link
Contributor

londoncalling commented Jan 17, 2018

@dperetti this is a good idea to differentiate and clarify the Compose filename for new users. However, It will be a bit of work because there are a lot of moving parts (asciinema, screen snaps, example code, and possibly more ...)

Let's see if we can get @johndmulhausen, @mistyhacks, or @JimGalasyn to weigh in on it for bandwidth right now. What do you guys think?

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary lifecycle/locked
Projects
None yet
Development

No branches or pull requests

10 participants