Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker stack deploy no longer supports volume-labels #1519

Closed
briantd opened this issue Apr 7, 2017 · 4 comments
Closed

docker stack deploy no longer supports volume-labels #1519

briantd opened this issue Apr 7, 2017 · 4 comments

Comments

@briantd
Copy link

briantd commented Apr 7, 2017

Expected behavior

The following docker command should be able to launch a stack with volumes that have volume labels

docker stack deploy -c docker-compose.yml my_app
e.g.

services:
  # Docker Swarm visualizer
  # See https://docs.docker.com/engine/tutorials/dockervolumes/#volume-labels for info on the ":z"
  viz:
    image: manomarks/visualizer
    ports:
      - 8081:8080
    networks:
      - jenkins-net
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:z
    deploy:
      placement:
        constraints: [node.role==manager]

Actual behavior

1 error(s) decoding:

  • invalid spec: /var/run/docker.sock:/var/run/docker.sock:z: unknown option: z

Information

  • Full output of the diagnostics from "Diagnose & Feedback" in the menu
    Docker for Mac: version: 17.03.1-ce-mac5 (b18e2a50c)
    macOS: version 10.12.4 (build: 16E195)
    logs: /tmp/3BC62945-262D-4DE5-83D6-6929A6993B92/20170406-170711.tar.gz
    [OK] vmnetd
    [OK] dns
    [OK] driver.amd64-linux
    [OK] virtualization VT-X
    [OK] app
    [OK] moby
    [OK] system
    [OK] moby-syslog
    [OK] db
    [OK] env
    [OK] virtualization kern.hv_support
    [OK] slirp
    [OK] osxfs
    [OK] moby-console
    [OK] logs
    [OK] docker-cli
    [OK] menubar
    [OK] disk

Steps to reproduce the behavior

  1. Put the example above into a docker-compose.yml
  2. Run docker stack deploy -c docker-compose.yml my_app
@dsheets
Copy link
Contributor

dsheets commented Apr 11, 2017

This looks like a docker/docker issue. :rw is also not accepted in compose files used with docker stack deploy -c but :ro is accepted. Please report this issue to docker/docker. I've marked this issue as status/0-more-info-needed so that we will auto-close it in 2 weeks if there is no further information to act upon.

@briantd
Copy link
Author

briantd commented Apr 12, 2017

Reported to docker/docker here --> moby/moby#32579

@docker-robott
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30d of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants