Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node container doesn't catch file change events from host machine #5046

Closed
2 tasks done
zeno-mioso opened this issue Nov 4, 2020 · 9 comments
Closed
2 tasks done

Comments

@zeno-mioso
Copy link

  • I have tried with the latest version of my channel (Stable or Edge)
  • I have uploaded Diagnostics
  • Diagnostics ID: AE23EDE6-1CFE-4B16-89DC-CF81F4AE94F5/20201104215924

Expected behavior

Actual behavior

Information

  • macOS Version: 10.14.6

Diagnostic logs

Docker for Mac: version 2.5.0

Steps to reproduce the behavior

  1. run ng serve from within node based container
  2. changing file on host machine doens't triggere events on guest running container
@Gatix
Copy link

Gatix commented Nov 5, 2020

I have the same issue even after checking gRPC FUSE for file sharing

@phonezawphyo
Copy link

phonezawphyo commented Nov 6, 2020

I have the same issue even after unchecking gRPC FUSE for file sharing. It works fine in 2.5.0 if it is checked.

  • macOS Version: 10.15.7

@0x3333
Copy link

0x3333 commented Nov 6, 2020

Same issue here.

@zeno-mioso zeno-mioso changed the title npm watcher doesn't trigger event to container npm node container doesn't catch file change events from host machine Nov 7, 2020
@masterkain
Copy link

every release breaks something in this area

@qhenkart
Copy link

same issue, Volumes are completely broken is gRPC FUSE is turned on. It simply times out. Turning it off works but now it does not catch any changes

@metaskills
Copy link

So this bug is in 3.0.0 now?

@qhenkart
Copy link

qhenkart commented Dec 12, 2020

I have noticed this bug in 3.0.

Upon further investigation, I realized that with gRPC fuse on, every time a container is mounted, all of the containers are remounted. If you have a watcher, then it will create a massive memory leak as every time a container is mounted, all of the currently mounted containers will reset, and rewatch the files. With a single node server, you probably won't notice, but with a bunch of micro services, it will time out

Without gRPC fuse checked, volumes don't seem to copy from the host machine and matches the OPs issue

@docker-robott
Copy link
Collaborator

Issues go stale after 90 days of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30 days of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants