Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container crashes and needs Docker restart when running multiple php processes with brianium/paratest with VirtioFS #6256

Closed
3 tasks done
freiondrej-lmc opened this issue Mar 29, 2022 · 20 comments

Comments

@freiondrej-lmc
Copy link

freiondrej-lmc commented Mar 29, 2022

  • I have tried with the latest version of Docker Desktop
  • I have tried disabling enabled experimental features - it happens only with VirtioFS enabled
  • I have uploaded Diagnostics
  • Diagnostics ID: C6A679AF-6692-4683-A3C9-D280385D8C21/20220329103249

Expected behavior

The process succeeds.

Actual behavior

The process freezes (in a different repo I managed to use strace and even it froze in the middle of output line) and Docker must be restarted to become operable again.

Information

  • macOS Version: 12.3 (21E230)
  • Intel chip or Apple chip: intel
  • Docker Desktop Version: 4.6.1 (76265)

Output of /Applications/Docker.app/Contents/MacOS/com.docker.diagnose check

Starting diagnostics

[PASS] DD0027: is there available disk space on the host?
[PASS] DD0028: is there available VM disk space?
[PASS] DD0031: does the Docker API work?
[PASS] DD0004: is the Docker engine running?
[PASS] DD0011: are the LinuxKit services running?
[PASS] DD0016: is the LinuxKit VM running?
[PASS] DD0001: is the application running?
[PASS] DD0018: does the host support virtualization?
[PASS] DD0017: can a VM be started?
[PASS] DD0015: are the binary symlinks installed?
[PASS] DD0003: is the Docker CLI working?
[PASS] DD0013: is the $PATH ok?
[PASS] DD0007: is the backend responding?
[PASS] DD0014: are the backend processes running?
[PASS] DD0008: is the native API responding?
[PASS] DD0009: is the vpnkit API responding?
[PASS] DD0010: is the Docker API proxy responding?
[PASS] DD0012: is the VM networking working?
[PASS] DD0032: do Docker networks overlap with host IPs?
[SKIP] DD0030: is the image access management authorized?
[PASS] DD0019: is the com.docker.vmnetd process responding?
[PASS] DD0033: does the host have Internet access?
No fatal errors detected.

Even when the container freezes (tried before and after restarting, every time same output).

Steps to reproduce the behavior

See the readme of the linked repo pls - https://github.com/freiondrej-lmc/paratest_issue_617.
I'm on the Team tier with username lmcondrejfrei.

@elbebass
Copy link

We did run in a similar issue, if needed I can use the provided repro to generate diagnostics or logs.

Information

  • macOs Version: 12.3
  • M1 Silicon
  • Docker Desktop 4.6.1 (76265)

@freiondrej-lmc
Copy link
Author

@elbebass that would be amazing, thank you. This is my first ever bug report to Docker, so I don't know much about how to provide additional details.

@elbebass
Copy link

@freiondrej-lmc let's wait and see. The occurring bug seems to crash everything - I did want to look at the logs inside the container but SSH did freeze too.

@cbajohr
Copy link

cbajohr commented Mar 30, 2022

I have a similar issue. One of my containers keeps freezing when the app outputs many lines in the log. Feels like a buffer overflow or something like that.
I also noticed that after upgrading to 4.6.0/4.6.1 the freezing container does not show any log ouput on docker-compose up. Only if I use docker attach or logs -f I'm getting Output from the logs.
After downgrading to 4.5.x the output appears again normally on compose up and the container did not freeze yet.
Happens with and without VirtioFS, makes no difference

@freiondrej-lmc
Copy link
Author

@cbajohr very interesting to hear that for you VirtioFS is not the differentiating factor 🤔 for me the problem does not occur when I disable VirtioFS, so I considered this to be a VirtioFS bug.

@Sopamo
Copy link

Sopamo commented Mar 30, 2022

We're seeing the same issue when enabling VirtioFS on M1 Macs. We do not have multiple php processes though, just a "normal" php-fpm server.
This is my diagnostics id: BDDFAC97-EA48-4C8A-BD3E-EA8A8113B1F4/20220330154530 which I created directly after one of those crashes

@panakour
Copy link

Similar issue to me also using the VirtioFS.

@maximilian-schwarz
Copy link

Same issue with VirtioFS. If i disable the experimental features "VirtioFS" the issue is gone

@boehsermoe
Copy link

Similar issue here...

@pleminh
Copy link

pleminh commented Apr 8, 2022

Similar issue.
Docker 4.6.1 with Virtualization framework + Enable VirtioFS accelerated directory sharing
macOS : 12.3.1 - Intel chip

For more details, it happens when a lot of file generation process is done. When many PHP processes are executed, the container involving a virtiofs mount is freeze/blocked.
We are forced to close Docker Desktop and restart it completely.

On the other hand, when there is no PHP process solicitation (e.g. mass file generation), it runs correctly.

Other issues:

During a composer install , we have
warning: cannot set modif./access times for /app/vendor/composer/ba83c91d/[...] Operation not permitted warning: cannot set permissions for /app/vendor/composer/ba83c91d/[...] Operation not permitted warning: set times/attribs failed for /app/vendor/composer/ba83c91d/[...]

Without virtiofs, everything works fine.

@fredericdalleau
Copy link

@freiondrej-lmc Hi, thanks for providing the reproduction for this issue.
We're looking into it!

@maximilian-schwarz
Copy link

@fredericdalleau Hello,
have you already looked at the issue?

@palgalik
Copy link

palgalik commented Apr 21, 2022

I can confirm that I have that issue too. (version 4.7.0 and 4.7.1)

@fredericdalleau
Copy link

Hey there, thanks for your patience, we've been informed that mac OS 12.4 beta 3 contains a fix for this issue.
I've ran the paratest 300 times in a row with virtiofs enabled. Let us know if you have any chance to try it and anything you can find!
@freiondrej-lmc thanks again for a great report!

@smepti
Copy link

smepti commented Apr 27, 2022

Hey there, thanks for your patience, we've been informed that mac OS 12.4 beta 3 contains a fix for this issue. I've ran the paratest 300 times in a row with virtiofs enabled. Let us know if you have any chance to try it and anything you can find! @freiondrej-lmc thanks again for a great report!

I have been using docker the last 4 hours on 12.4 beta 3 and it's great.
Incredible speed, we have a huge project, the speed of its work on a mac is now comparable to Linux.
It seems to me that VirtioFS is the most breakthrough update of Docker Desktop for Mac.

Thank you for your work!

P.S
Beta available to everyone
https://beta.apple.com/sp/betaprogram/enroll?locale=en#macos

@maximilian-schwarz
Copy link

maximilian-schwarz commented May 6, 2022

Mac OS 12.4 beta 3 fixed the issue. Currently my docker is running without any problems since 3 weeks 🥳

@GM-Alex
Copy link

GM-Alex commented May 20, 2022

@maximilian-schwarz Good to hear that there is a solution in the making that works.

@panakour
Copy link

Mac OS 12.4 fixed the issue.

@docker-robott
Copy link
Collaborator

Issues go stale after 90 days of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30 days of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests