Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code highlighting/colours illegible in dark mode #82

Open
ghost opened this issue Aug 29, 2020 · 6 comments · May be fixed by #362
Open

Code highlighting/colours illegible in dark mode #82

ghost opened this issue Aug 29, 2020 · 6 comments · May be fixed by #362

Comments

@ghost
Copy link

ghost commented Aug 29, 2020

Thanks for the great tutorial - it's incredibly useful. However, when reading it in dark mode, some of the code highlighting is very low contrast and hard to read. Screenshots below.

Screenshot 2020-08-29 at 11 20 50

Screenshot 2020-08-29 at 11 19 50

@carusog
Copy link

carusog commented Mar 16, 2021

I was going to open this same issue. I see it's open since 8 months at the time of this comment.
Any update on this? Is it OK if we investigate and open a PR to fix it? Should we wait for it?
I'd be more than happy to help, but I'd like to avoid to spend time on an abandoned project.
Thanks for your reply.

@YakutovDmitriy
Copy link

The same issue here

@MaxArt2501
Copy link

It's been almost two years and still nothing has changed for this issue (which is the most upvoted, too). Do the maintainers even have time to take care of this?
And it's not like no efforts have been made: PR #63 even predates this issue and it's still there, unmerged. Can that be improved? Another PR is needed?

I really liked this tutorial image, but it really should be maintained.

@netskink
Copy link

same

@yogitheboss
Copy link

yogitheboss commented Jan 30, 2023

This issue hasn't been resolved yet

@pmogan77 pmogan77 linked a pull request Feb 15, 2023 that will close this issue
@pmogan77
Copy link

pmogan77 commented Mar 2, 2023

Hello! I wanted to follow up and ask if there is any feedback you could provide for my fix. Was it helpful, or is there anything else that could be improved? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants