Inconsistent Error Handling in nat Package #113
Conversation
Signed-off-by: Ashwek Swamy <ashwekswamy@protonmail.com>
| // We don't need to check for an error because we're going to | ||
| // assume that any error would have been found, and reported, in NewPort() | ||
| start, end, _ := ParsePortRangeToInt(p.Port()) | ||
| return start, end, nil |
There was a problem hiding this comment.
I'm a bit on the fence here; the Int() function does not have an error-return in its signature, so even if the error would not be ignored, there's nowhere to send it to (other than logging or a panic);
Lines 80 to 87 in fa09c95
The Range() function does have an error return, so the error can be handled (or ignored) by consumers.
Was there an issue you ran into, other than error-handling being inconsistent?
(for transparency; the code in this repository is quite old, and not all parts are very well designed; we're still evaluating the future of this repository, and possibly breaking it up / moving code elsewhere)
There was a problem hiding this comment.
No, inconsistent error handling was the only issue.
Okay, if there is a possibility that the code is being moved or broken up, this PR won't contribute much. I guess we can just close it.
Fixes #112