Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

RackHD support #698

Merged
merged 33 commits into from Sep 24, 2017
Merged

RackHD support #698

merged 33 commits into from Sep 24, 2017

Conversation

chungers
Copy link
Contributor

This PR moves the code from the Dell/EMC RackHD infrakit plugin into the main infrakit repo and make the plugin a built-in that can be started up with infrakit plugin start rackhd.

  • Moved the plugin source code into pkg/provider package namespace and preserved commit history
  • Code changes to make the plugin compile and build
  • Temporarily disabled tests since 3 tests are failing (TODO)
  • Made the options in the rackhd plugin package exported / public so that we can set the options in configuration JSONs.
  • Added driver code so that the rackhd plugin can be started with the CLI infrakit plugin start and as rackhd kind.

CC - @spiegela @ajeetraina

Signed-off-by: David Chung david.chung@docker.com

spiegela and others added 30 commits February 24, 2017 10:41
Interface and mocks may move into gorackhd project once
proven out in this project.
create a new logo to have before DockerCon showcase. Also added a small blurb at the beginning to throw some more marketing magic on it.

Signed-off-by: Kendrick Coleman <kendrickcoleman@gmail.com>
  * provisioning and destructions are now prevented from nodes with
  active workflows
  * descriptions now include node IP addresses as learned from Ohai node
  catalog
  * Some cleanup/refactoring

  TODO: update tests to match
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
David Chung added 2 commits September 24, 2017 03:09
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "rackhd" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353608520
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Chung <david.chung@docker.com>
@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #698 into master will decrease coverage by 1.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   50.02%   48.65%   -1.38%     
==========================================
  Files          80       82       +2     
  Lines        8653     8897     +244     
==========================================
  Hits         4329     4329              
- Misses       4008     4252     +244     
  Partials      316      316
Impacted Files Coverage Δ
...der/codedellemc/rackhd/plugin/instance/instance.go 0% <0%> (ø)
...ider/codedellemc/rackhd/plugin/instance/builder.go 0% <0%> (ø)
pkg/x/remoteboot/remoteboot.go 20.25% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef7750...23971e7. Read the comment docs.

@chungers chungers merged commit 07a8e08 into docker-archive:master Sep 24, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
…ve#698)

* Added maintainers to allow other products to find us =)
chungers pushed a commit to chungers/infrakit that referenced this pull request Oct 1, 2017
…ve#698)

* Added maintainers to allow other products to find us =)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants