Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Added Ben to maintainers list #711

Merged
merged 2 commits into from Oct 2, 2017
Merged

Conversation

FrenchBen
Copy link
Contributor

No description provided.

Signed-off-by: French Ben <frenchben@docker.com>
MAINTAINERS Outdated
@@ -36,6 +37,11 @@
Email = "david.gageot@docker.com"
GitHub = "dgageot"

[people.FrenchBen]
Name = "French Ben"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you swapped your "first" and "last" name here, compared to the other repo 😉 https://github.com/docker/kitematic/blob/master/MAINTAINERS#L34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha which one is better? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're real name 😇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your - damn you autocorrect

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #711 into master will increase coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #711     +/-   ##
=========================================
+ Coverage   44.74%   46.65%   +1.9%     
=========================================
  Files          61       85     +24     
  Lines        7469     9404   +1935     
=========================================
+ Hits         3342     4387   +1045     
- Misses       3875     4684    +809     
- Partials      252      333     +81
Impacted Files Coverage Δ
pkg/plugin/group/group.go 43.98% <0%> (-0.42%) ⬇️
pkg/store/swarm/swarm.go 62.68% <0%> (ø)
pkg/types/pointer.go 75% <0%> (ø)
pkg/types/duration.go 51.72% <0%> (ø)
pkg/template/help.go 65.51% <0%> (ø)
pkg/types/hierarchy.go 73.91% <0%> (ø)
pkg/types/spec.go 47.82% <0%> (ø)
pkg/template/util.go 60% <0%> (ø)
pkg/store/etcd/v3/etcd.go 0% <0%> (ø)
pkg/x/remoteboot/remoteboot.go 20.25% <0%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f1bae...3c92abf. Read the comment docs.

Signed-off-by: French Ben <frenchben@docker.com>
@chungers chungers merged commit 961825e into docker-archive:master Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants