New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new msgpack implementation #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgowan
force-pushed
the
new_msgpack_implementation
branch
3 times, most recently
from
February 23, 2015 16:40
fad4fb1
to
3d7fef7
Compare
dmcgowan
force-pushed
the
new_msgpack_implementation
branch
from
April 4, 2015 02:07
3d7fef7
to
ff1f64a
Compare
Benchmark results from master
|
This looks awesome! Are these benchmarks checked in somewhere? |
Not yet, let me make a PR and get them into master |
dmcgowan
force-pushed
the
new_msgpack_implementation
branch
from
April 4, 2015 23:05
ff1f64a
to
2e5991a
Compare
- Reintroduce SendTo and ReceiveFrom - Use raw message when receiving from spdy - Zero copy in-mem transport - Remove raw connection encoding Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Update Send and Receive objects to lock access and save their encoder/decoder. Additionally use a buffered writer on encode. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
dmcgowan
force-pushed
the
new_msgpack_implementation
branch
from
April 4, 2015 23:19
2e5991a
to
341cc36
Compare
In memory pipe benchmark results
|
dmcgowan
added a commit
that referenced
this pull request
Apr 4, 2015
Use new msgpack implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change include use of a new msgpack implementation based on a fork of github.com/vmihailenco/msgpack. The changes were to support libchan were extended types, interface encoding, raw messages, and removing of a non-standard time encoding.
Additional cleanup changes to support this PR include removing of the raw connection encoding in the spdy implementation which was never defined in the libchan protocol.
Includes:
What this enables:
fixes #47