request free ports from the OS #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -504,18 +504,20 @@ func SpawnClientServerTest(t *testing.T, host string, client ClientRoutine, serv | |||
| endServer := make(chan bool) | |||
| listenWait := make(chan bool) | |||
|
|
|||
| listener, listenErr := net.Listen("tcp", host) | |||
There was a problem hiding this comment.
Passing in the host as an argument shouldn't be needed any more, just fill this in with "localhost:0"
|
Yes, this change is needed. Do you think you can make the update I suggested to clean it up. Also please sign the commit according to https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work. Then I will get this merged. Thanks! |
|
Definitely already working on it, do I need sign every commit? |
|
Yes add the sign off to every commit |
|
LGTM, just please add sign off to first commit. |
passing host string is no longer required Signed-off-by: Drew Wells <drew.wells00@gmail.com>
drewwells
force-pushed
the
feature/portconflicts
branch
from
9da9ecb
to
767d547
Compare
|
Sorry about that, rebased to one commit with sign. |
|
Excellent! thanks LGTM |
dmcgowan
added a commit
that referenced
this pull request
Mar 30, 2015
request free ports from the OS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were hardcoded to ports that may not be available on the system. Some ports were reused in subsequent tests which caused tests to occasionally fail when the system didn't release these ports.