This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
handle SIGCHLD when running as child subreaper #369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under child subreaper mode, it's useful for nsenter to be able to reap child processes. We have seen cases where spawned user processes were not reaped properly (nvm-sh/nvm#650)
I dont see how we can write a test case for this yet. Manual steps to reproduce this are:
Thanks @soareschen for the test image