Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

handle SIGCHLD when running as child subreaper #369

Merged
merged 1 commit into from
Feb 10, 2015

Conversation

dqminh
Copy link
Contributor

@dqminh dqminh commented Feb 10, 2015

When running under child subreaper mode, it's useful for nsenter to be able to reap child processes. We have seen cases where spawned user processes were not reaped properly (nvm-sh/nvm#650)

I dont see how we can write a test case for this yet. Manual steps to reproduce this are:

# terminal 1
> docker pull soareschen/ubuntu-zsh
> docker run -it --rm --name test-nvm soareschen/ubuntu-zsh zsh
> source ~/.nvm/nvm.sh
> ps auxf # no defunct processes

# terminal 2
> docker exec -it test-nvm zsh
> source ~/.nvm/nvm.sh
> ps auxf # lots of defunct processes before this patch, and no defunct processes after

Thanks @soareschen for the test image

When running under child subreaper mode, it's useful for nsenter to be able to
reap child processes. We have seen cases where spawned user processes wasnt
reaped properly (nvm-sh/nvm#650)

Signed-off-by: Daniel, Dao Quang Minh <dqminh89@gmail.com>
@vmarmol
Copy link
Contributor

vmarmol commented Feb 10, 2015

LGTM

@mrunalp
Copy link
Contributor

mrunalp commented Feb 10, 2015

Thanks, looking good. I will quickly test it out.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 10, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Feb 10, 2015
handle SIGCHLD when running as child subreaper
@mrunalp mrunalp merged commit d6fae7b into docker-archive:master Feb 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants