This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add arch support for ARMv8 and PowerPC, and fix ARMv7 #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Conrad <adconrad@0c3.net>
See: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=571503e10045c89af951962ea0bb783482663aad Signed-off-by: Adam Conrad <adconrad@0c3.net>
Signed-off-by: Adam Conrad <adconrad@0c3.net>
|
LGTM |
1 similar comment
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Apr 10, 2015
Add arch support for ARMv8 and PowerPC, and fix ARMv7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ARMv8 commit should be self-explanatory.
The ARMv7 commit is fixing something that's been wrong since day 1, though the lack of complaints due to it probably shows how often this code-path isn't followed on ARM. Still, I saw it in passing and fixed it anyway.
The PowerPC commit is similarly self-explanatory to the ARMv8 one, though also shows that syscall_linux_64.go is fairly poorly named. Really, syscall_linux* should probably go away and be replaced by an import C that calls the glibc setuid() and setgid() wrappers, since they magically always hit the right syscall, and we don't have to have knowledge of what arch supports what, but I went for the most minimally invasive fix here just to make it build happily.
Tested as backports to docker 1.5.0 on amd64, i386, armhf, arm64, powerpc, and ppc64el.