Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add arch support for ARMv8 and PowerPC, and fix ARMv7 #524
Conversation
adconrad
added some commits
Apr 10, 2015
|
LGTM |
|
LGTM |
added a commit
that referenced
this pull request
Apr 10, 2015
mrunalp
merged commit ae812bd
into
docker:master
Apr 10, 2015
1 check passed
janky
Jenkins build Libcontainer-PRs 379 has succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adconrad commentedApr 10, 2015
The ARMv8 commit should be self-explanatory.
The ARMv7 commit is fixing something that's been wrong since day 1, though the lack of complaints due to it probably shows how often this code-path isn't followed on ARM. Still, I saw it in passing and fixed it anyway.
The PowerPC commit is similarly self-explanatory to the ARMv8 one, though also shows that syscall_linux_64.go is fairly poorly named. Really, syscall_linux* should probably go away and be replaced by an import C that calls the glibc setuid() and setgid() wrappers, since they magically always hit the right syscall, and we don't have to have knowledge of what arch supports what, but I went for the most minimally invasive fix here just to make it build happily.
Tested as backports to docker 1.5.0 on amd64, i386, armhf, arm64, powerpc, and ppc64el.