New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong stopCh type in Watch/WatchTree #58

Closed

vcastellm opened this issue Sep 17, 2015 · 1 comment

vcastellm commented Sep 17, 2015

As defined in the interface https://github.com/docker/libkv/blob/master/store/store.go#L64-L69 the stopCh won't work as intended.

I see from the tests that it's not used at all and I guess you're not using it anywhere else.
https://github.com/docker/libkv/blob/master/testutils/utils.go#L102-L103

This poppedup to me when trying to use a watch in my project.

At least in etcd the stopCh must be a send-only type ch. for the purpose of stopping the watch. Also in libkv it's the intended usage: https://github.com/docker/libkv/blob/master/store/etcd/etcd.go#L227

I can take care of this refactor. Note that may result in breaking API changes.

Author

vcastellm commented Sep 17, 2015

The test confused me sorry, declaring the channel as bidirectional solves the issue I was having.

vcastellm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment