Skip to content

Commit

Permalink
Format network address using %v instead of %p
Browse files Browse the repository at this point in the history
If we encounter an error setting an interface's IPv4 or IPv6 address,
log the addresses we tried to use using the %v specifier rather than %q.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com> (github: nalind)
  • Loading branch information
nalind committed Mar 16, 2016
1 parent f7d0b2d commit 260dd27
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions osl/interface_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@ func configureInterface(iface netlink.Link, i *nwIface) error {
}{
{setInterfaceName, fmt.Sprintf("error renaming interface %q to %q", ifaceName, i.DstName())},
{setInterfaceMAC, fmt.Sprintf("error setting interface %q MAC to %q", ifaceName, i.MacAddress())},
{setInterfaceIP, fmt.Sprintf("error setting interface %q IP to %q", ifaceName, i.Address())},
{setInterfaceIPv6, fmt.Sprintf("error setting interface %q IPv6 to %q", ifaceName, i.AddressIPv6())},
{setInterfaceIP, fmt.Sprintf("error setting interface %q IP to %v", ifaceName, i.Address())},
{setInterfaceIPv6, fmt.Sprintf("error setting interface %q IPv6 to %v", ifaceName, i.AddressIPv6())},
{setInterfaceMaster, fmt.Sprintf("error setting interface %q master to %q", ifaceName, i.DstMaster())},
}

Expand Down

0 comments on commit 260dd27

Please sign in to comment.