Preserve link-local IPv6 on container's lo & allow link-local only IPv6 networks #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavenugo
reviewed
May 15, 2017
| @@ -413,6 +418,10 @@ func (a *Allocator) getPredefinedPool(as string, ipV6 bool) (*net.IPNet, error) | |||
| } | |||
| } | |||
|
|
|||
| if !supported { | |||
There was a problem hiding this comment.
hmm. wont this check cause a legitimate pool exhaustion mis-categorized as ErrNotSupported ?
There was a problem hiding this comment.
No, because getPredefined() returns the list of predefined pools, not the list of available predefined pools.
thaJeztah
reviewed
Jul 5, 2017
network.go
Outdated
| if err == ipamapi.ErrNotSupported && cfg.PreferredPool == "" && ipVer == 6 { | ||
| *cfgList = nil | ||
| *infoList = nil | ||
| logrus.Infof("IPAM driver does not support autoallocation for IPv%d", ipVer) |
There was a problem hiding this comment.
This can be simplified to just;
logrus.Info("IPAM driver does not support auto-allocation for IPv6")
ipamapi/contract.go
Outdated
| @@ -54,6 +54,7 @@ var ( | |||
| ErrIPOutOfRange = types.BadRequestErrorf("Requested address is out of range") | |||
| ErrPoolOverlap = types.ForbiddenErrorf("Pool overlaps with other one on this address space") | |||
| ErrBadPool = types.BadRequestErrorf("Address space does not contain specified address pool") | |||
| ErrNotSupported = types.BadRequestErrorf("Do not support requested operation") | |||
There was a problem hiding this comment.
Perhaps (to be consisted with other messages);
ErrNotSupported = types.BadRequestErrorf("Requested operation is not supported")
|
ping, er I mean |
- For backward compatibility because some applications expect that Signed-off-by: Alessandro Boch <aboch@docker.com>
|
Thanks @thaJeztah. Addressed your comments. |
- In case the IPAM driver does not support auto-allocation of IPv6 address pools, libnetwork to be more lenient so that containers' interfaces can have link-local only addresses Signed-off-by: Alessandro Boch <aboch@docker.com>
|
ping @fcrisciani @mavenugo @abhinandanpb PTAL |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to moby/moby/issues/33099
Overrides #1751
As explained in moby/moby#33099 (comment), it is better to keep IPv6 enabled on the container's loopback interface, for backward compatibility with applications which expect that. (We could do this only if enabled on the host, but doing it regardless seems more robust and should not cause any ipv6 advertise packet be sent out the container.)
Also, restore support for creating an
--ipv6network with no routable subnet. Libnetwork core will be ok if the IPAM driver cannot auto allocate a subnet for the network.