Fix TestValidRemoteDriver GetCapabilities errors #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed a second warning as well by adding the Delete endpoint; no warnings/errors anymore; |
arkodg
reviewed
May 15, 2019
libnetwork_test.go
Outdated
| mux.HandleFunc(fmt.Sprintf("/%s.CreateNetwork", driverapi.NetworkPluginEndpointType), func(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json") | ||
| fmt.Fprintf(w, "null") | ||
| }) | ||
| mux.HandleFunc(fmt.Sprintf("/%s.DeleteNetwork", driverapi.NetworkPluginEndpointType), func(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Content-Type", "application/vnd.docker.plugins.v1+json") | ||
| fmt.Fprintf(w, "{}") |
There was a problem hiding this comment.
looks like it should be fmt.Fprintf(w, "null")
There was a problem hiding this comment.
I guess both work; let me update
thaJeztah
force-pushed
the
fix_TestValidRemoteDriver
branch
from
670774a
to
4f25d4e
Compare
|
@arkodg updated; PTAL |
This test was producing error messages due to missing endpoints in the plugin API; ``` === RUN TestValidRemoteDriver ERRO[0039] error getting capability for valid-network-driver due to NetworkDriver.GetCapabilities: 404 page not found ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_TestValidRemoteDriver
branch
from
4f25d4e
to
1cf5b18
Compare
euanh
approved these changes
Jun 14, 2019
This was referenced Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this change from #2118
This test was producing error messages due to missing endpoints
in the plugin API;