Renaming driver name to lower case for usability #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping to surface Signed-off-by: msabansal <sabansal@microsoft.com>
|
Tests also need to be updated slightly. Fixed and ran again. (they will not fail as the driver name is case insensitive in HNS) C:\gopath\src\github.com\docker\libnetwork\drivers\windows>godep go test -v C:\gopath\src\github.com\docker\libnetwork\drivers\windows> |
|
LGTM |
1 similar comment
|
LGTM |
aboch
added a commit
that referenced
this pull request
Mar 1, 2016
Renaming driver name to lower case for usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added portmapping support for the windows driver. (Still requires some work in HNS to be fully supported).
CI results from TP5 Build:
C:\gopath\src\github.com\docker\libnetwork\drivers\windows>godep go test -v
=== RUN TestNAT
--- PASS: TestNAT (0.85s)
=== RUN TestTransparent
--- PASS: TestTransparent (13.40s)
PASS
ok github.com/docker/libnetwork/drivers/windows 14.318s
C:\gopath\src\github.com\docker\libnetwork\drivers\windows>godep go test -v
=== RUN TestNAT
--- PASS: TestNAT (0.87s)
=== RUN TestTransparent
--- PASS: TestTransparent (13.57s)
PASS
ok github.com/docker/libnetwork/drivers/windows 14.502s